Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain log rate spikes: Fix state reset on refetch. #136177

Merged
merged 4 commits into from
Jul 13, 2022
Merged

[ML] Explain log rate spikes: Fix state reset on refetch. #136177

merged 4 commits into from
Jul 13, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 12, 2022 •
edited
Loading

Summary

Part of #136265.

Adds a fix to reset the state when a user restarts the analysis.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 12, 2022
@walterra walterra self-assigned this Jul 12, 2022
@walterra walterra requested a review from a team as a code owner July 12, 2022 08:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 380.1KB 380.1KB +22.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

peteharverson
peteharverson approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit 43b16a9 into elastic:main Jul 13, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 13, 2022
@walterra walterra deleted the ml-aiops-fix-refetch-reset branch July 13, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @kibanamachine